Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18993 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 3) ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18993/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18993/6//COMMIT_MSG@19 PS6, Line 19: hasImmutableColumn > nit: Should it be 'hasImmutableColumns'? Done http://gerrit.cloudera.org:8080/#/c/18993/6/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: http://gerrit.cloudera.org:8080/#/c/18993/6/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@488 PS6, Line 488: changeImmutable > nit: To be consistent with c++ API, maybe we can replace the method with 's There are some difference in the implemention and usage between Java and C++. In C++, adding column and altering column share the same KuduColumnSpec, it's actually convenient to create and alter a table like: builer.AddColumn("imm_val")->Immutable()->Type(...)->...; table_alterer->AlterColumn("int_val")->Immutable(); but in Java, they are separeted, using ColumnSchemaBuilder and AlterTableOptions. Here, using 'changeImmutable' is also to keep the same style with other functions in AlterTableOptions, like 'changeComment', 'changeEncoding', and etc. -- To view, visit http://gerrit.cloudera.org:8080/18993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfdcd123296803a3b5e856ec5eaac49c05b7f8d Gerrit-Change-Number: 18993 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 09 Oct 2022 02:58:26 +0000 Gerrit-HasComments: Yes
