Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18993 )

Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema 
(part 3)
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18993/7/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java:

http://gerrit.cloudera.org:8080/#/c/18993/7/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java@558
PS7, Line 558:           (step.getType() == 
AlterTableRequestPB.StepType.ALTER_COLUMN &&
             :            step.getAlterColumn().getDelta().hasImmutable())) {
> Also fix a bug that should use 'hasImmutable()' but not 'hasImmutable()'.
should use 'hasImmutable()' but not 'getImmutable()'.



--
To view, visit http://gerrit.cloudera.org:8080/18993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdfdcd123296803a3b5e856ec5eaac49c05b7f8d
Gerrit-Change-Number: 18993
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 19 Oct 2022 13:41:04 +0000
Gerrit-HasComments: Yes

Reply via email to