Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 2: (3 comments) LINT and IWYU builds are failing, please make sure they pass. Probably, that something related to the parent patch. http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc@1173 PS2, Line 1173: "127.0.0.1" nit: instead of this, I'd expect setting opts.bind_interface to 127.0.0.1 and then calling addrs[0].ToString() http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc@1201 PS2, Line 1201: picojson What's picojson? http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util.cc@696 PS2, Line 696: // This Get() will time out until shutdown, when the promise is set. : bool timed_out; : shut_down_promise_.Get(timeout_millis, &timed_out); : if (!timed_out) break; I'd suggest get rid of the Get() method which has bogus signature and simply use the Wait(const MonoDelta&) here instead. That should allow to get rid of ASAN warning reported by the pre-commit build. -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 19 Oct 2022 19:54:44 +0000 Gerrit-HasComments: Yes
