Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc@1173 PS2, Line 1173: "127.0.0.1" > nit: instead of this, I'd expect setting opts.bind_interface to 127.0.0.1 a Done http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util-test.cc@1201 PS2, Line 1201: picojson > What's picojson? picojson is the JSON library that the jwt-cpp library is using to handle JSON data http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/2/src/kudu/util/jwt-util.cc@696 PS2, Line 696: shut_down_promise_.Set(true); : if (jwks_update_thread_ != nullptr) jwks_update_thread_->Join(); : } : > I'd suggest get rid of the Get() method which has bogus signature and simpl Done -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 07 Nov 2022 11:00:36 +0000 Gerrit-HasComments: Yes
