Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19152 )
Change subject: [tserver] validate scanner TTL vs RPC connection timeout ...................................................................... Patch Set 1: > My immature ideas extends by this patch: > > 1. In java client, 'keepAlivePeriodMs' should be set less than > min(--rpc_default_keepalive_time_ms, --scan_ttl_ms), I think > sending at least twice keepalive requests is better during > min(--rpc_default_keepalive_time_ms, --scan_ttl_ms). > 2. Java client and kudu server's some parameters should match. > Maybe kudu masters can keep some key parameters such as > 'rpc_default_keepalive_time_ms', client get them and adjust its > local parameters. This patch is an attempt to make the parameters of Kudu tablet servers to be more consistent, so RPC connections of idle scanners aren't closed inadvertently by the server side. As for the consistency between the client and the server side configuration, there isn't much can be done programmatically unless the client side has enough credentials to call GetFlags(). However, we cannot assume that's the case because GetFlags() require super-user/admin credentials. -- To view, visit http://gerrit.cloudera.org:8080/19152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1439dfb6eb82ba2be0472547b04e5a692879535 Gerrit-Change-Number: 19152 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 22 Oct 2022 15:54:05 +0000 Gerrit-HasComments: No
