Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19152 )
Change subject: [tserver] validate scanner TTL vs RPC connection timeout ...................................................................... [tserver] validate scanner TTL vs RPC connection timeout This patch adds a group validator for --scanner_ttl_ms and --rpc_default_keepalive_time_ms flags. The validator outputs a warning (not an error though) if the TTL for an idle scanner is greater than the timeout for an idle RPC connection. Even if an idle scanner is kept alive at the server side for some time, Kudu servers periodically close connections that have been idle at least for --rpc_default_keepalive_time_ms time interval. So, setting the --rpc_default_keepalive_time_ms flag to a greater or equal value than --scanner_ttl_ms helps keeping yet-to-be-used connections to idle scanners open, avoiding inadvertent closure and re-opening connections to scanners that might yet be sent continuation scan requests. The new constraint also helps to work around one particular bug [1] in the Kudu Java client. I didn't add a test for the newly added validator, but I manually verified that the warning is output as expected when necessary. [1] https://issues.apache.org/jira/browse/KUDU-3169 Change-Id: If1439dfb6eb82ba2be0472547b04e5a692879535 Reviewed-on: http://gerrit.cloudera.org:8080/19152 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yuqi Du <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/tserver/scanners.cc 1 file changed, 28 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Verified Yuqi Du: Looks good to me, but someone else must approve Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If1439dfb6eb82ba2be0472547b04e5a692879535 Gerrit-Change-Number: 19152 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
