Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19166 )
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h File src/kudu/cfile/cfile_reader.h: http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h@350 PS1, Line 350: Status SeekAtOrAfter(const EncodedKey& key, > warning: function 'kudu::cfile::CFileIterator::SeekAtOrAfter' has a definit Done http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h@351 PS1, Line 351: bool* exact_match, bool cache_seeked_value = false); > warning: invalid case style for parameter 'SeekAtOrAfter' [readability-iden Done http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc File src/kudu/tablet/index_skipscan-test.cc: http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@186 PS1, Line 186: return num_matching; > warning: method 'CreateSchema' can be made static [readability-convert-memb Done http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@259 PS1, Line 259: > warning: floating point literal has suffix 'f', which is not uppercase [rea Done http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@659 PS1, Line 659: ASSERT_EQ(num_matching, results.size()); > warning: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TE Done -- To view, visit http://gerrit.cloudera.org:8080/19166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce Gerrit-Change-Number: 19166 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Wed, 26 Oct 2022 08:50:59 +0000 Gerrit-HasComments: Yes
