Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19166 )

Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.h
File src/kudu/tablet/cfile_set.h:

http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.h@318
PS6, Line 318:   int64_t index_skip_num_seeks_cutoff_ = 0;
> warning: invalid case style for private member '_index_skip_first_seek_' [r
Done


http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:

http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc@19
PS6, Line 19: #include <algorithm>
> warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath
Done


http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc@481
PS6, Line 481: }
> warning: 1st function call argument is an uninitialized value [clang-analyz
Done



--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Comment-Date: Thu, 22 Dec 2022 08:29:43 +0000
Gerrit-HasComments: Yes

Reply via email to