Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 )
Change subject: [python] Make clang_tidy work with python 3.6.9 ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19187/1/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: http://gerrit.cloudera.org:8080/#/c/19187/1/build-support/clang_tidy_gerrit.py@79 PS1, Line 79: decode() I guess this might fail in Python 2.x if the output contains non-ascii characters, but I guess we have no other choice here, right? http://gerrit.cloudera.org:8080/#/c/19187/2/build-support/kudu_util.py File build-support/kudu_util.py: http://gerrit.cloudera.org:8080/#/c/19187/2/build-support/kudu_util.py@121 PS2, Line 121: in nit: add space before 'in' -- To view, visit http://gerrit.cloudera.org:8080/19187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ce1503422152c6ecd27f382795e11f1df64d67f Gerrit-Change-Number: 19187 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Nov 2022 06:06:36 +0000 Gerrit-HasComments: Yes
