Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 )
Change subject: [python] Make clang_tidy work with python 3.6.9 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19187/1/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: http://gerrit.cloudera.org:8080/#/c/19187/1/build-support/clang_tidy_gerrit.py@79 PS1, Line 79: decode() > I have no idea what would happen in that case. I'm not sure how realistic i Yup, but just to give you some more context: a lot of Kudu build infrastructure is still running on Python2. And that's de-facto so for many other projects as well, regardless of whatever they declare w.r.t. support of Python2 :) However, since our code is mostly ASCII, I don't think there is a high chance that decode() in Python2 would barf here on non-ASCII characters. -- To view, visit http://gerrit.cloudera.org:8080/19187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ce1503422152c6ecd27f382795e11f1df64d67f Gerrit-Change-Number: 19187 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 04 Nov 2022 16:41:37 +0000 Gerrit-HasComments: Yes
