Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/18846/19/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18846/19/src/kudu/client/client.cc@2319 PS19, Line 2319: data_->SetRequestId(request_id); : return Status::OK(); > The definition fo SetRequestId is void. In KuduScanner::SetRequestId bad status may be returned, keep consistency? http://gerrit.cloudera.org:8080/#/c/18846/19/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/19/src/kudu/tserver/tablet_service.cc@3038 PS19, Line 3038: "scanner_id", req->scanner_id()); > Done To check whether some text occured in log, you can use ScopedRegisterSink. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 20 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 04:16:54 +0000 Gerrit-HasComments: Yes
