Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 19: (6 comments) http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.h@2796 PS18, Line 2796: /// Set a request id for the scan to trace the whole process. > It's recommend to describe more about it for the user faced API. Done http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.h@2796 PS18, Line 2796: request id > nit: request id Done http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.h@3163 PS18, Line 3163: Status NextBatch(internal::ScanBatchDataInterface* batch); > nit: keep all of them in order. Done http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.h@3357 PS18, Line 3357: , if table > nit: request id Done http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/client/client.cc@1761 PS18, Line 1761: if (request_id.empty()) { > How about just check request_id should not be empty, and set a random in th Done http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/18/src/kudu/tserver/tablet_service.cc@2754 PS18, Line 2754: TRACE_EVENT1("tserver", "TabletServiceImpl::HandleNewScanRequest", > The tracing is used like https://kudu.apache.org/docs/troubleshooting.html# Done -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 19 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 02 Nov 2022 04:41:49 +0000 Gerrit-HasComments: Yes
