Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19230 )
Change subject: [util] method for IP address matching against patterns ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19230/1/src/kudu/util/net/net_util-test.cc File src/kudu/util/net/net_util-test.cc: http://gerrit.cloudera.org:8080/#/c/19230/1/src/kudu/util/net/net_util-test.cc@342 PS1, Line 342: ASSERT_TRUE(IsAddressMatching(a, { b })); How about one more test case where we have a second, non-matching IP address to the vector? http://gerrit.cloudera.org:8080/#/c/19230/1/src/kudu/util/net/net_util-test.cc@379 PS1, Line 379: ASSERT_TRUE(IsAddressMatching(a0, { wp })); Here too, we could have a test case with a matching and a non-matching port. http://gerrit.cloudera.org:8080/#/c/19230/1/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: http://gerrit.cloudera.org:8080/#/c/19230/1/src/kudu/util/net/net_util.h@199 PS1, Line 199: patterns Calling this 'patterns' is a bit confusing. It led me to believe this supports CIDR, netmask, or some partial wildcard (i.e. 192.168.1.*). Maybe that's just me though. -- To view, visit http://gerrit.cloudera.org:8080/19230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f6bac9a5fa038d27ba5924f0fd7d5a50b72a7aa Gerrit-Change-Number: 19230 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 21:34:02 +0000 Gerrit-HasComments: Yes
