Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19230 )
Change subject: [util] a function to check if IP address is among specified ...................................................................... Patch Set 3: Code-Review+1 (2 comments) small nits only http://gerrit.cloudera.org:8080/#/c/19230/3/src/kudu/util/net/net_util-test.cc File src/kudu/util/net/net_util-test.cc: http://gerrit.cloudera.org:8080/#/c/19230/3/src/kudu/util/net/net_util-test.cc@321 PS3, Line 321: The address should match itself I'm not sure if any matching is done here, could you clarify? http://gerrit.cloudera.org:8080/#/c/19230/3/src/kudu/util/net/net_util-test.cc@341 PS3, Line 341: Sockaddr n; nit: maybe add a small blurb for this scenario -- To view, visit http://gerrit.cloudera.org:8080/19230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f6bac9a5fa038d27ba5924f0fd7d5a50b72a7aa Gerrit-Change-Number: 19230 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 08:39:56 +0000 Gerrit-HasComments: Yes
