Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19231 )
Change subject: WIP: KUDU-3357 endpoints for proxied RPCs ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19231/1/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/19231/1/src/kudu/server/rpc_server.cc@270 PS1, Line 270: already > nit: double 'already' Done http://gerrit.cloudera.org:8080/#/c/19231/1/src/kudu/server/rpc_server.cc@361 PS1, Line 361: && > shouldn't this be || ? Well, that actually should be checking just for server_state against UNINITIALIZED since rpc_proxied_addresses_ is populated in RpcServer::Init(). Done. -- To view, visit http://gerrit.cloudera.org:8080/19231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic300250556d3f6e522a71923bed6aa5cd45375ea Gerrit-Change-Number: 19231 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 23:19:39 +0000 Gerrit-HasComments: Yes
