Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19231 )
Change subject: KUDU-3357 endpoints for proxied RPCs ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19231/4/src/kudu/common/wire_protocol.proto File src/kudu/common/wire_protocol.proto: http://gerrit.cloudera.org:8080/#/c/19231/4/src/kudu/common/wire_protocol.proto@94 PS4, Line 94: proxy_rpc_addresses nit: Do you think having this named to rpc_proxy_addresses is more consistent with the naming style of the flag? Same below. http://gerrit.cloudera.org:8080/#/c/19231/4/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19231/4/src/kudu/integration-tests/create-table-itest.cc@585 PS4, Line 585: hp0 nit: Maybe call this hp to keep it consistent with below? -- To view, visit http://gerrit.cloudera.org:8080/19231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic300250556d3f6e522a71923bed6aa5cd45375ea Gerrit-Change-Number: 19231 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 19 Nov 2022 23:44:40 +0000 Gerrit-HasComments: Yes
