Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 )
Change subject: [Flag] Check flags consistency when setting a flag ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/19237/1//COMMIT_MSG Commit Message: PS1: Tests are missing. Please add tests to cover the newly added functionality. http://gerrit.cloudera.org:8080/#/c/19237/1//COMMIT_MSG@9 PS1, Line 9: Currently Kudu will not check flags consistency : when setting a flag. This sounds a bit confusing because it might be attributed to the case when just starting Kudu servers with flags set, where regular and group flag validators are run. Please add a clarification that this is about GenericService::SetFlag() RPC. http://gerrit.cloudera.org:8080/#/c/19237/1//COMMIT_MSG@10 PS1, Line 10: When Kudu restart, this inconsistency : flags will cause restarting failed. I'm not sure I understand what you meant by that. The flags set via GenericService::SetFlag() aren't persisted, so a restarted Kudu processes doesn't retain any settings. http://gerrit.cloudera.org:8080/#/c/19237/1//COMMIT_MSG@17 PS1, Line 17: or Should this be 'and'? I'm not sure this makes any sense as it's written now. -- To view, visit http://gerrit.cloudera.org:8080/19237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e6e37e0f4e72a2cc3d2316248961315f1757ebc Gerrit-Change-Number: 19237 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Nov 2022 18:42:36 +0000 Gerrit-HasComments: Yes
