Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19237 )
Change subject: [Flag] Check flags consistency when setting a flag ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19237/1/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/19237/1/src/kudu/util/flags.cc@551 PS1, Line 551: bool CheckFlagsInconsistence() { > This current code misses running the regular (i.e. non-custom) validators f Ah, actually trying to set --rpc_max_message_size is better since that's a run-time flag. But checking whether it's possible to set a non-runtime flags is a good test scenario to have as well. -- To view, visit http://gerrit.cloudera.org:8080/19237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e6e37e0f4e72a2cc3d2316248961315f1757ebc Gerrit-Change-Number: 19237 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 12 Nov 2022 19:43:34 +0000 Gerrit-HasComments: Yes
