Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19243 )
Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19243/2//COMMIT_MSG Commit Message: PS2: We strive to add test coverage to the new functionality, at least some basic test scenarios to spot regressions if that's mistakenly removed or broken. Could you update the SetFlagForAllTest.TestSetFlagForAll in kudu-tool-test.cc at least to add a usage of the tool with the newly added flag set? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/19243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I716c2a8be4a6041aa28b5191b55022158536d97c Gerrit-Change-Number: 19243 Gerrit-PatchSet: 2 Gerrit-Owner: yejiabao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 03:33:29 +0000 Gerrit-HasComments: Yes
