Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19243 )
Change subject: [Tools] support set_flag_for_all in tserver use optional parameter 'force'. ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19243/5/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19243/5/src/kudu/tools/kudu-tool-test.cc@8678 PS5, Line 8678: SCOPED_TRACE(stderr); What's the idea behind adding this trace if the ASSERT_STR_CONTAINS() outputs the contents of the 'stderr' anyways if triggered? http://gerrit.cloudera.org:8080/#/c/19243/5/src/kudu/tools/kudu-tool-test.cc@8680 PS5, Line 8680: } Since you updated this and fixed the bug in the parameters for Substitute(), maybe you could also update this code to check for the presence of "result: NO_SUCH_FLAG" substring stderr? -- To view, visit http://gerrit.cloudera.org:8080/19243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I716c2a8be4a6041aa28b5191b55022158536d97c Gerrit-Change-Number: 19243 Gerrit-PatchSet: 5 Gerrit-Owner: yejiabao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Comment-Date: Wed, 16 Nov 2022 21:07:23 +0000 Gerrit-HasComments: Yes
