Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc@397 PS16, Line 397: NewTempWritableFile(opts, &name_[0], &created_filename, &tmp_file); > Right: I'd think it worked as that. And once the instance of this file is s/... instance of this file .../... instance of this class .../ http://gerrit.cloudera.org:8080/#/c/18468/18/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/18/src/kudu/util/jwt-util-test.cc@410 PS18, Line 410: void TempTestDataFile::Delete() { : if (deleted_) return; : deleted_ = true; : if (remove(name_.c_str()) != 0) { : std::cout << "Error deleting temp file; " << strerror(errno) << std::endl; : abort(); : } : } I guess this isn't needed once switched to proper usage of NewTempWritableFile. -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 18 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 19:31:07 +0000 Gerrit-HasComments: Yes
