Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc@397 PS16, Line 397: e(Env::Default(), contents, created_filename); > s/... instance of this file .../... instance of this class .../ Done http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc@410 PS16, Line 410: JWTHelper jwt_helper; : Status status = jwt_helper.Init(jwks_file.Filename(), true); : EXPECT_OK(status); : JWKSSnapshotPtr jwks = jwt_helper.GetJWKS(); : ASSERT_FALSE(jwks->IsEmpty()); : ASSERT_EQ(2, jwks->GetRSAPublicKeyNum()); : : > This function is copied from Impala, which did not use NewTempWritableFile( Done http://gerrit.cloudera.org:8080/#/c/18468/16/src/kudu/util/jwt-util-test.cc@1225 PS16, Line 1225: > I'm totally fine with addressing that in its own patch, especially if some I absolutely agree with adding the mentioned test scenarios, but also agree that this commit is not the best place for it. I'll make sure they are included in a following patch. -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 20 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 19 Nov 2022 18:59:10 +0000 Gerrit-HasComments: Yes
