Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/4/src/kudu/server/server_base.cc@661 PS4, Line 661: std::move(jwt_verifier) Remove the definition of jwt_verifier at line 645 and replace this std::move(...) with std::make_shared<JwtVerifier>("", true) Overall, prefer std::make_shared over constructing std::shared_ptr via regular constructor since the former is more efficient in most implementations in terms of making just one memory allocation instead of two: https://en.cppreference.com/w/cpp/memory/shared_ptr/make_shared -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Sat, 19 Nov 2022 02:03:00 +0000 Gerrit-HasComments: Yes
