Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18470 )
Change subject: server: link in kudu_jwt_util ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/18470/9/src/kudu/server/server_base.cc@644 PS9, Line 644: std::shared_ptr<JwtVerifier> jwt_verifier(std::make_shared<KeyBasedJwtVerifier>("", true)); Is this a functional verifier? In other words, can it verify any tokens at all? Also, could you help me to understand where's the call for the JwtVerifier::Init() is supposed to happen: just here, or as a part of Messenger::Init(), or somewhere else? -- To view, visit http://gerrit.cloudera.org:8080/18470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfe694d553ebead6afbf58dc773bf5534f1d099a Gerrit-Change-Number: 18470 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 09 Dec 2022 20:34:08 +0000 Gerrit-HasComments: Yes
