Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact ...................................................................... Patch Set 25: (10 comments) http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.h@269 PS25, Line 269: use for compact Replace with "to compact" http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.h@270 PS25, Line 270: GetColumnIdsForCompact GetColumnIdsToCompact http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.h@401 PS25, Line 401: MonoTime last_update_time_ nit: A comment describing this variable would be nice to have. http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc@65 PS25, Line 65: compact compaction http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc@65 PS25, Line 65: deal the delta file with full " : "of delete op Replace with "compact delta files with only delete ops" http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc@948 PS25, Line 948: for Replace with "to" http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc@958 PS25, Line 958: op delta nit: "op only delta" http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/delta_tracker.cc@967 PS25, Line 967: // The delta file with full of delete op may affect the scan speed. : // We pick out the cold delta file (that means it has not been updated for a long time) : // that meets the quantity requirements to do compcat to reduce the impact on scan : // performance. Replace with: "Get the cold delta files with delete only ops to be compacted" http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/diskrowset-test.cc File src/kudu/tablet/diskrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/diskrowset-test.cc@657 PS25, Line 657: a Delete http://gerrit.cloudera.org:8080/#/c/18503/25/src/kudu/tablet/diskrowset-test.cc@684 PS25, Line 684: The compact will schedule job to deal with the delta file with full of delete op Replace with: Compaction of the delete op only delta files will be scheduled. -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 25 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 15:59:47 +0000 Gerrit-HasComments: Yes
