Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact ...................................................................... Patch Set 26: (5 comments) http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.h@401 PS26, Line 401: ttps://issues.apache.org/jira/browse/KUDU-1625 nit: can be simplified by ”KUDU-1625" http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.cc@66 PS26, Line 66: ." nit: add an extra space between . and " http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.cc@373 PS26, Line 373: std::lock_guard<rw_spinlock> l(update_time_lock_); nit: better to move it after the logs below. http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.cc@969 PS26, Line 969: https://issues.apache.org/jira/projects/KUDU/issues/KUDU-3367 nit: can be simplified by ”KUDU-3367" http://gerrit.cloudera.org:8080/#/c/18503/26/src/kudu/tablet/delta_tracker.cc@972 PS26, Line 972: shared_lock<rw_spinlock> l(update_time_lock_); The lock scope is a bit of large, how about assign it to a temp variable to minimize the lock scope? -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 26 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 04:05:05 +0000 Gerrit-HasComments: Yes
