Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19332 )
Change subject: [tools] fix mistake in LeaderStepDown() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/19332/1/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19332/1/src/kudu/tools/tool_action_tablet.cc@196 PS1, Line 196: if (new_leader_uuid && leader_uuid == *new_leader_uuid) { Thanks for fixing this. nit: Not necessary to address in this patch - I am thinking if it would make sense to compare "current_leader_uuid "and "new_leader_uuid". If both are equal, same condition would apply i.e., no need to call DoLeaderStepDown. Something like this: if ((new_leader_uuid && leader_uuid == *new_leader_uuid) || (current_leader_uuid && new_leader_uuid && *current_leader_uuid == *new_leader_uuid) { cout << Substitute("Requested new leader $0 is already the leader",leader_uuid) << endl; return Status::OK(); } -- To view, visit http://gerrit.cloudera.org:8080/19332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ee51c2b99c37f1eec96d94a6538c0fd78f39be2 Gerrit-Change-Number: 19332 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 09 Dec 2022 11:12:37 +0000 Gerrit-HasComments: Yes
