Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19332 )
Change subject: [tools] fix mistake in LeaderStepDown() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19332/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19332/1//COMMIT_MSG@10 PS1, Line 10: scenarios > nit: If possible, could you please add the scenario that hit SIGSEGV . I don't know what's the exact list (that's the issue), but at least the following failed when I ran dist-test last time: * AdminCliTest.TestLeaderTransferToEvictedPeer * AdminCliTest.TestGracefulLeaderStepDown * AdminCliTest.TestLeaderTransferToNonVoter http://dist-test.cloudera.org/job?job_id=aserbin.1670568093.132444 http://gerrit.cloudera.org:8080/#/c/19332/1/src/kudu/tools/tool_action_tablet.cc File src/kudu/tools/tool_action_tablet.cc: http://gerrit.cloudera.org:8080/#/c/19332/1/src/kudu/tools/tool_action_tablet.cc@196 PS1, Line 196: if (new_leader_uuid && leader_uuid == *new_leader_uuid) { > Thanks for fixing this. I'm not sure I understand why the same condition applies for new_leader_uuid and current_leader_uuid since their semantics is different. The UUID provided by new_leader_uuid is the target, while current_leader_uuid shows where to send the request for current_leader_uuid to step down, so current_leader_uuid doesn't have semantics of "a new leader to establish", as I understand. -- To view, visit http://gerrit.cloudera.org:8080/19332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ee51c2b99c37f1eec96d94a6538c0fd78f39be2 Gerrit-Change-Number: 19332 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 09 Dec 2022 15:52:59 +0000 Gerrit-HasComments: Yes
