Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: KUDU-3367 [compaction] add supplement to gc algorithm ...................................................................... Patch Set 31: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.h@400 PS31, Line 400: live count nit: live row count http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.cc@67 PS31, Line 67: FLAGS_tablet_history_max_age_sec nit: --tablet_history_max_age_sec Use faced flags would be better to use two dashes ("--") instead of FLAGS_*. http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.cc@974 PS31, Line 974: nit: assignment -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 31 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 10 Dec 2022 17:42:16 +0000 Gerrit-HasComments: Yes
