Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: KUDU-3367 [compaction] add supplement to gc algorithm ...................................................................... Patch Set 32: Code-Review+1 (3 comments) Overall looks good to me, just a few naming and documantation nits to address. http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/31/src/kudu/tablet/delta_tracker.cc@64 PS31, Line 64: DEFINE_uint64(all_delete_op_delta_file_cnt_for_compact, 1, : "The compaction scheduler will not deal the compact REDO delta store " : "files with only delete ops until the file count threshold reac > It's redo delta store files here, I've updated the comments. OK, thanks for the update. Could you shed a bit of light on the following: what might be a scenario when it's necessary to set this threshold to 10 instead of 1? I guess it might be worth mentioning that in the flag's description to let people know what's the intuition behind setting a proper value. Thanks! http://gerrit.cloudera.org:8080/#/c/18503/32/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/32/src/kudu/tablet/delta_tracker.cc@64 PS32, Line 64: all_delete_op_delta_file_cnt_for_compact naming nit: please use either '..._for_compaction' or '..._to_compact', i.e. rename this to be either 'all_delete_op_delta_file_cnt_for_compaction' or 'all_delete_op_delta_file_cnt_to_compact' http://gerrit.cloudera.org:8080/#/c/18503/32/src/kudu/tablet/delta_tracker.cc@65 PS32, Line 65: "The compaction scheduler will not deal the compact REDO delta store " : "files with only delete ops until the file count threshold reached. " : "Works with --tablet_history_max_age_sec." I'd update this description a bit (maybe, also add the information on when to set this flag to 10 instead of 1): The minimum number of REDO delta files containing only ancient DELETE operations to schedule a major delta compaction on them. A DELETE operation is considered ancient if it was applied more than --tablet_history_max_age_sec seconds ago. -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 32 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 06:41:33 +0000 Gerrit-HasComments: Yes
