Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/scan_token-test.cc@530 PS6, Line 530: // Projection excluding auto incrementing column > Add test case without setting projected columns. Verify that auto_increment Done http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/schema.h@728 PS6, Line 728: ram [ > auto_incrementing column is only added to schema when the schema is built b Done http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/6/src/kudu/client/schema.cc@682 PS6, Line 682: if (spec->data_->primary_key) { : if (data_->key_cols_unique) { : return Status::InvalidArgument( : "primary key specified by both SetPrimaryKey() and on a " : "specific column", : spec->data_->name); : } > change code as: Done -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 12 Dec 2022 13:38:46 +0000 Gerrit-HasComments: Yes
