Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/scan_token-internal.cc@207 PS2, Line 207: for (const int column_idx : message.projected_column_idx()) { : column_indexes.push_back(column_idx); : } > Right now I would lean towards including the auto incrementing column as th That's fine for Impala integration. Impala always create Kudu scan token with projected columns. For update/delete, the projected columns of scan token consist all key columns, including auto_incrementing_id. But for statements like "create table as select *", auto_incrementing_id has to be omitted from projected columns. Please add a comment with TODO here. http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.h@493 PS2, Line 493: Set the column to be a non-unique primary key of the table. > I changed the implementation to what you suggested. It really simplifies th Please add comments to describe the behavior. http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.h@638 PS2, Line 638: This may be used to specify a > Done Please add comments to describe the behavior. -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 06 Dec 2022 18:14:45 +0000 Gerrit-HasComments: Yes
