Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add query id to trace the whole query process ...................................................................... Patch Set 24: (12 comments) http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.h@3385 PS24, Line 3385: /// IntoUniqueScanner(client_.get(), *tokens[0], &scanner); IntoUniqueScanner is not a client API, avoid to expose it in usage sample. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc@1767 PS24, Line 1767: } else { nit: else can be omitted. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc@2325 PS24, Line 2325: } else { nit: else can be omitted. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.h File src/kudu/client/scan_token-internal.h: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.h@98 PS24, Line 98: std::string query_id_ = ""; Different with builtin bool and uint64_t, std::string has default constructor to init query_id_ as "", so assign to "" can be omitted. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.cc@440 PS24, Line 440: MonoTime deadline = MonoTime::Now() + client->default_admin_operation_timeout(); What is deadline used for? http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc@451 PS24, Line 451: // Create schema : KuduSchema schema; : { : KuduSchemaBuilder builder; : builder.AddColumn("col")->NotNull()->Type(KuduColumnSchema::INT64)->PrimaryKey(); : ASSERT_OK(builder.Build(&schema)); : } : : // Create table : shared_ptr<KuduTable> table; : { : unique_ptr<KuduPartialRow> split(schema.NewRow()); : ASSERT_OK(split->SetInt64("col", 0)); : unique_ptr<KuduTableCreator> table_creator(client_->NewTableCreator()); : #pragma GCC diagnostic push : #pragma GCC diagnostic ignored "-Wdeprecated-declarations" : ASSERT_OK(table_creator->table_name("table") : .schema(&schema) : .add_hash_partitions({ "col" }, 4) : .split_rows({ split.release() }) : .num_replicas(1) : .Create()); : #pragma GCC diagnostic pop : ASSERT_OK(client_->OpenTable("table", &table)); : } : // Create session : shared_ptr<KuduSession> session = client_->NewSession(); : session->SetTimeoutMillis(10000); : ASSERT_OK(session->SetFlushMode(KuduSession::AUTO_FLUSH_BACKGROUND)); : : // Insert rows : for (int i = -100; i < 100; i++) { : unique_ptr<KuduInsert> insert(table->NewInsert()); : ASSERT_OK(insert->mutable_row()->SetInt64("col", i)); : ASSERT_OK(session->Apply(insert.release())); : } : ASSERT_OK(session->Flush()); how about use TestWorkload to create table and generate data? http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc@505 PS24, Line 505: while (scanner->HasMoreRows()) { Is it needed to scan all data? if not, use if-statement is enough. Other places are the same. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc@508 PS24, Line 508: ASSERT_STRINGS_ANY_MATCH(capture_logs.logged_msgs(), : "query_id: query-id-for-test tablet_id:"); : ASSERT_STRINGS_ANY_MATCH(capture_logs.logged_msgs(), : "query_id: query-id-for-test scanner_id:"); nit: indent http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_server-test.cc@2870 PS24, Line 2870: TEST_F(TabletServerTest, TestScanWithQueryId) { What does this test want to check? Better to add some comments. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc@2757 PS24, Line 2757: " nit: add a comma http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc@3040 PS24, Line 3040: " nit: add a comma http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tserver.proto@396 PS24, Line 396: tablets tablets. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 24 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 17 Dec 2022 04:41:35 +0000 Gerrit-HasComments: Yes
