Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add query id to trace the whole query process ...................................................................... Patch Set 25: (11 comments) > Patch Set 24: > > (12 comments) http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.h@3385 PS24, Line 3385: /// > IntoUniqueScanner is not a client API, avoid to expose it in usage sample. Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc@1767 PS24, Line 1767: } > nit: else can be omitted. Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/client.cc@2325 PS24, Line 2325: data_->SetQueryId(query_id); > nit: else can be omitted. Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.h File src/kudu/client/scan_token-internal.h: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.h@98 PS24, Line 98: std::string query_id_; > Different with builtin bool and uint64_t, std::string has default construct Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-internal.cc@440 PS24, Line 440: case KuduScanner::READ_AT_SNAPSHOT: > What is deadline used for? Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc@505 PS24, Line 505: ASSERT_OK(builder.AddLowerBound(*lower_bound)); > Is it needed to scan all data? if not, use if-statement is enough. Yes, it needs. For-statement is used to test continue-request case. http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/client/scan_token-test.cc@508 PS24, Line 508: ASSERT_EQ(4, tokens.size()); : ASSERT_EQ(60, CountRows(tokens)); : NO_FATALS(VerifyTabletInfo(tokens)); : } > nit: indent Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_server-test.cc@2870 PS24, Line 2870: // Test for a scan with query id in server side. > What does this test want to check? Better to add some comments. Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc@2757 PS24, Line 2757: > nit: add a comma Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tablet_service.cc@3040 PS24, Line 3040: > nit: add a comma Done http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/18846/24/src/kudu/tserver/tserver.proto@396 PS24, Line 396: tablets > tablets. Done -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 25 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 02:02:03 +0000 Gerrit-HasComments: Yes
