Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )
Change subject: [log] Reduce prompt log printing frequency ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/1//COMMIT_MSG@9 PS1, Line 9: too frequently : for the trash table > Do you mean that I continue to use the function, just adjust the time frequ If the inputs for the UpdateStats() changes, it might start printing much more often that you'd expect (by default the interval to re-check compaction ops by the maintenance manager is 250ms). Also, printing based on the count might backfire, as Yuingchun mentioned. http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@9 PS5, Line 9: UpdateStats() function print too frequently But that's only in case of disabling particular type of compaction, isn't it? http://gerrit.cloudera.org:8080/#/c/19375/5//COMMIT_MSG@10 PS5, Line 10: trash table What is 'trash table'? http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92 PS5, Line 92: Maybe, make it something to be round in the number of minutes? If you don't like 300, then 600 might be a good option. http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@380 PS5, Line 380: Don't you want to update this to be configurable as well? -- To view, visit http://gerrit.cloudera.org:8080/19375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Dec 2022 18:14:07 +0000 Gerrit-HasComments: Yes
