Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )
Change subject: [log] Reduce prompt log printing frequency ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/7//COMMIT_MSG@14 PS7, Line 14: update_stats_print_prompt_log_interval_s There are some more cases in src/kudu/tablet/tablet_replica_mm_ops.cc we have to deal with? http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19375/5/src/kudu/tablet/tablet_mm_ops.cc@92 PS5, Line 92: 600 > Done I guess Alexey meant change it to a flag in minute unit? I agree that we don't need such a accurate control in seconds. -- To view, visit http://gerrit.cloudera.org:8080/19375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 7 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 04:50:16 +0000 Gerrit-HasComments: Yes
