Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18503 )
Change subject: KUDU-3367 [compaction] add supplement to gc algorithm ...................................................................... Patch Set 34: Code-Review+1 (1 comment) > I have updated the flag's description according to your comments. > Could you help me to reconfirm? Thanks a lot. Great, thanks! Just one nit. http://gerrit.cloudera.org:8080/#/c/18503/34/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/18503/34/src/kudu/tablet/delta_tracker.cc@68 PS34, Line 68: "--tablet_history_max_age_sec seconds ago." nit: add a space after the period -- To view, visit http://gerrit.cloudera.org:8080/18503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b26737dffecc17688b42188da959b2ba16351ed Gerrit-Change-Number: 18503 Gerrit-PatchSet: 34 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 02:28:04 +0000 Gerrit-HasComments: Yes
