Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica edit_metadata delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/19357/1/src/kudu/tablet/tablet_metadata.cc@71 PS1, Line 71: only rowset ids are removed from " : "tablet metadata, the related blocks are kept on file system. You " : "can start the server to check whether the operation is worked as " : "expect, if it is, then shutdown the server and run 'kudu fs check " : "--repair=true' to remove orphaned blocks, or use the backup " : "tablet-metadata to roll back. > Got it. Thanks for you explanation! Because there is an existing flag --enable_tablet_orphaned_block_deletion above, --keep_orphaned_blocks may make users confused a bit. How about rename to --enable_tablet_orphaned_block_adding? -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 24 Dec 2022 10:49:14 +0000 Gerrit-HasComments: Yes
