Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19357 )
Change subject: [tools] Add 'kudu local_replica edit_metadata delete_rowsets' to delete rowsets from tablet ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG@11 PS3, Line 11: a single point cluster What's 'a single point cluster'? Probably, you meant 'a single node cluster'? http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG@11 PS3, Line 11: corruption corrupted http://gerrit.cloudera.org:8080/#/c/19357/3//COMMIT_MSG@19 PS3, Line 19: introduce introduces http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19357/3/src/kudu/tools/tool_action_local_replica.cc@1250 PS3, Line 1250: edit_matadata Could we have a sub-command 'delete_rowsets' for a new 'metadata' or 'tmeta' command? Keeping the commands hierarchically structured helps to find the required functionality easier for an operator. Also, it's more in-line with the approach used for the 'cmeta' command. -- To view, visit http://gerrit.cloudera.org:8080/19357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2cf9035babf4c3af4c238cebe8dcecd2c65848f Gerrit-Change-Number: 19357 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Wed, 28 Dec 2022 03:27:52 +0000 Gerrit-HasComments: Yes
