Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19375 )
Change subject: [log] Reduce prompt log printing frequency ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Overall looks good, just a nit on the naming of the flag. Thanks! http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19375/9//COMMIT_MSG@15 PS9, Line 15: update_stats_print_prompt_log_interval_s nit: since 'prompt' doesn't seem to be very relevant to what the flag is doing, maybe rename it into --update_stats_log_throttling_interval_sec ? http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/19375/9/src/kudu/tablet/tablet_mm_ops.cc@92 PS9, Line 92: update_stats_print_prompt_log_interval_s Whoops, it seems I forgot to point to the fact that 'prompt' in the name of this flag didn't look relevant. Could you rename this into something like update_stats_log_throttling_interval_sec ? -- To view, visit http://gerrit.cloudera.org:8080/19375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06ecf355c504a931b7c3d193c129c2a757bf0e03 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 9 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 30 Dec 2022 18:39:55 +0000 Gerrit-HasComments: Yes
