Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 )
Change subject: [KUDU-3430] Implement getting flags filter logic in tool side ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/server/generic_service.cc@50 PS7, Line 50: Whether disable f > nit: Whether Done http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/tools/kudu-tool-test.cc@148 PS7, Line 148: DECLARE_bool(show_attributes); > nit: reorder it to keep them in lexicographic order Done http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/tools/kudu-tool-test.cc@7823 PS7, Line 7823: disable_flag_filter_logic > nit: how about rename to disable_flag_filter_logic_on_server ? Done -- To view, visit http://gerrit.cloudera.org:8080/19393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858 Gerrit-Change-Number: 19393 Gerrit-PatchSet: 8 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Jan 2023 08:48:34 +0000 Gerrit-HasComments: Yes
