Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19393 )
Change subject: [KUDU-3430] Implement getting flags filter logic in tool side ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/server/generic_service.cc@50 PS7, Line 50: This flag is used nit: Whether http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19393/7/src/kudu/tools/kudu-tool-test.cc@148 PS7, Line 148: DECLARE_bool(disable_gflag_filter_logic_for_testing); nit: reorder it to keep them in lexicographic order -- To view, visit http://gerrit.cloudera.org:8080/19393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a2ddc2540d7aa70d3dd2e6c4101bb227e94c858 Gerrit-Change-Number: 19393 Gerrit-PatchSet: 7 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Jan 2023 03:51:47 +0000 Gerrit-HasComments: Yes
