Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19404 )
Change subject: KUDU-3357 proxied RPCs for multi-master Kudu clusters ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Just a few nits, otherwise LGTM http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc File src/kudu/integration-tests/client-proxied-rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc@353 PS1, Line 353: addressed nit: addresses http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc@356 PS1, Line 356: SetFaultTolerant Would a non-fault tolerant scan fail immediately instead of timing out? http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/master/master.cc@253 PS1, Line 253: could not find any RPC advertised address for masters I think this should be reworded a bit, this makes me think that the addresses were parsed successfully, but were e.g. unreachable. Maybe go with something like: "[unable to parse | invalid ]RPC advertised address for masters" -- To view, visit http://gerrit.cloudera.org:8080/19404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id834d5fae8dcc2230de9f6b6429334c24052011a Gerrit-Change-Number: 19404 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 10 Jan 2023 10:41:06 +0000 Gerrit-HasComments: Yes
