Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19404 )
Change subject: KUDU-3357 proxied RPCs for multi-master Kudu clusters ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc File src/kudu/integration-tests/client-proxied-rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc@353 PS1, Line 353: addressed > nit: addresses Done http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/integration-tests/client-proxied-rpc-test.cc@356 PS1, Line 356: SetFaultTolerant > Would a non-fault tolerant scan fail immediately instead of timing out? Nope: a fault-tolerant scan is simply a scan at a particular snapshot (READ_AT_SNAPSHOT), so if any of the server components fails while scanning, re-attempting the scan would provide the same result. Otherwise, it could return different number of rows since by default a scan uses the latest available snapshot. But it's not crucial to have a fault-tolerant scanner here, indeed: having READ_LATEST scanner is enough. http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/19404/1/src/kudu/master/master.cc@253 PS1, Line 253: could not find any RPC advertised address for masters > I think this should be reworded a bit, this makes me think that the address Done -- To view, visit http://gerrit.cloudera.org:8080/19404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id834d5fae8dcc2230de9f6b6429334c24052011a Gerrit-Change-Number: 19404 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 11 Jan 2023 03:41:40 +0000 Gerrit-HasComments: Yes
