Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19278 )
Change subject: [tools] Add test to generate heavy rowset compaction ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19278/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19278/5//COMMIT_MSG@13 PS5, Line 13: The test may require a follow-up change to accomodate recently : added change for 'memory budgeting of CompactRowSetsOp' > What's the essence of the anticipated change? With new flags introduced in memory budgeting patch (https://github.com/apache/kudu/commit/1556a353e60c5d555996347cbd46d5e5a6661266), the idea is to use those flags and check the memory usage with and without budgeting patch in action. The next change can do something like this: 1. Record the memory usage with default settings (i.e. memory budgeting change disabled). 2. Enable the memory budgeting change by enabling main flag and setting other flags (introduced) in accordance with memory usage requirements of the test itself. 3. Run the test again and record the memory usage. This time, compaction should be skipped when the memory requirement goes beyond the certain size. Since this additional change would require more iterations of tuning of flags in order to get to the exact scenario, I would prefer to have that in separate patch. -- To view, visit http://gerrit.cloudera.org:8080/19278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4ec03f1bf0f7936f8fb054948f87e71333f824 Gerrit-Change-Number: 19278 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Jan 2023 11:40:51 +0000 Gerrit-HasComments: Yes
