Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19278 )
Change subject: [tools] Add test to generate heavy rowset compaction ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19278/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19278/5//COMMIT_MSG@13 PS5, Line 13: The test may require a follow-up change to accomodate recently : added change for 'memory budgeting of CompactRowSetsOp' > If so, then I'm not sure that I understand the purpose of this particular p The reason behind having this patch is to document steps to reproduce high memory usage by compaction during heavy rowset updates. As this is long running test (~15 minutes) and ends up consuming heavy memory, the test may behave differently on different test nodes (depending on existing load running on those systems), so it makes sense to have it disabled by default. It can be enabled and used as and when required to reproduce such scenarios. Even if new flags used in memory budgeting patch is included in this test, I think we may still need to keep it disabled because step 1 stated above will anyway take time and consume memory. -- To view, visit http://gerrit.cloudera.org:8080/19278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4ec03f1bf0f7936f8fb054948f87e71333f824 Gerrit-Change-Number: 19278 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Jan 2023 05:58:13 +0000 Gerrit-HasComments: Yes
