Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19413 )
Change subject: KUDU-3406 corrected estimate for ancient UNDO delta size ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG@16 PS2, Line 16: So, if a : delta file was lazily loaded without stats being read, DeltaTracker : assumed all its deltas were ancient. > The message should be there if the deltas are ancient -- that's not a probl Right. That's exactly what happened during my testing. I had just generated load with all default flags, so there was no chance that those deltas could be ancient. http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG@19 PS2, Line 19: the > The meaning here is that those deltas were not picked up by the compaction. Ah! my bad! Thanks for the grammatical tidbit :-) http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG@20 PS2, Line 20: the How about "those" ? http://gerrit.cloudera.org:8080/#/c/19413/3/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/19413/3/src/kudu/tablet/rowset.h@115 PS3, Line 115: delta nit: delta is -- To view, visit http://gerrit.cloudera.org:8080/19413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17bddae86f84792caf14fb1e11a6e1c0d7a92b56 Gerrit-Change-Number: 19413 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 12:24:42 +0000 Gerrit-HasComments: Yes
