Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19413 )
Change subject: KUDU-3406 corrected estimate for ancient UNDO delta size ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG@16 PS2, Line 16: So, if a : delta file was lazily loaded without stats being read, DeltaTracker : assumed all its deltas were ancient. > Right. That's exactly what happened during my testing. I had just generated I see. Yep, that makes sense. If so, then certainly it means that more or less a regular workload might lead to a situation that dense_node-itest exposes. That's good to know, thanks! http://gerrit.cloudera.org:8080/#/c/19413/2//COMMIT_MSG@20 PS2, Line 20: the > How about "those" ? Done http://gerrit.cloudera.org:8080/#/c/19413/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19413/3//COMMIT_MSG@19 PS3, Line 19: lead > Good catch! ack http://gerrit.cloudera.org:8080/#/c/19413/3//COMMIT_MSG@19 PS3, Line 19: lead > nit: led Done http://gerrit.cloudera.org:8080/#/c/19413/3/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/19413/3/src/kudu/tablet/rowset.h@115 PS3, Line 115: delta > nit: delta is Done -- To view, visit http://gerrit.cloudera.org:8080/19413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17bddae86f84792caf14fb1e11a6e1c0d7a92b56 Gerrit-Change-Number: 19413 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 17 Jan 2023 02:56:53 +0000 Gerrit-HasComments: Yes
