Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] Return immediately after the limit number of rows have been dumped ...................................................................... [tools] Return immediately after the limit number of rows have been dumped The --nrows flag for 'local_replica dump rowset' just limits the last output row count, but doesn't take effect on the row count dumped from rowsets internally of the tool, due to which there maybe too much useless work. This patch improves it by returning immediately after --nrows of rows have been dumped.. Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Reviewed-on: http://gerrit.cloudera.org:8080/19369 Tested-by: Kudu Jenkins Reviewed-by: Wang Xixu <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/compaction.h M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_local_replica.cc 12 files changed, 111 insertions(+), 42 deletions(-) Approvals: Kudu Jenkins: Verified Wang Xixu: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
