Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19369 )
Change subject: [tools] Return immediately after the limit number of rows have been dumped ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.h@180 PS6, Line 180: // If 'rows_left' is nullptr, there is no limit on the number of rows to dump. : // If the content of 'rows_left' equal to or less than 0, no rows will be dumped. > It seems this part is not relevant for this function anymore. Done http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc File src/kudu/tablet/rowset.cc: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tablet/rowset.cc@53 PS6, Line 53: > style nit: the indent here should be 2 spaces, not 4 Done http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1037 PS6, Line 1037: No matter if there are any rows to be printed, the metadata will be printed. > When the --dump_metadata flag is set to 'true', the metadata is always prin Done http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1091 PS6, Line 1091: It's not needed to read the next block when reach rows limit > How about: Done http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097 PS6, Line 1097: larger > nit: greater Done http://gerrit.cloudera.org:8080/#/c/19369/6/src/kudu/tools/tool_action_local_replica.cc@1097 PS6, Line 1097: will always been : // printed in pairs. > ... are always printed in pairs Done -- To view, visit http://gerrit.cloudera.org:8080/19369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia758ba910fccbbc06ac6c59a795574fb86d4e279 Gerrit-Change-Number: 19369 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 16 Jan 2023 08:46:55 +0000 Gerrit-HasComments: Yes
